rphsoftware/OneLoader

Have a system in place to ensure loads from some directories never fail.

rphsoftware opened this issue · 2 comments

rphsoftware commented

The facesets directory can cause issues with save files and the save&load plus mod. When a modded save is made, and the mod providing custom faces is uninstalled, the save&load plus mod might fail to load the face sprite.
This proposal suggests oneloader gaslights the mods and returns fake data if the file doesn't exist, instead of failing the attempted load. This would only work for some directories, not all of them, and with specific configuration.

Initially the following only the following directory is proposed:
/img/facesets

Additionally, attempted reads would result in a warning being printed in the log like so:
[VIOLATION] Attempted to load /img/facesets/nonexistentfile.png, but it does not exist

FoGsesipod commented

I think I should add just incase, as far as I know this "file not found" crash also happens without save&load plus.

rphsoftware commented

I think I should add just incase, as far as I know this "file not found" crash also happens without save&load plus.

This system would be applied no matter the installed mods, with the option to add extra per-mod overrides in the future to fix them post-release from within OneLoader. /img/facesets would be always used as a "safe folder"