Drop `--database` and `--no-database`, split?/drop `sqliterepo_c`
kontura opened this issue · 5 comments
-
The
--database
and--no-database
options could be dropped entirely in favor of users deliberately callingsqliterepo_c
- EL7 is the only significant beneficiary, and EL7 will be EOL in a year
- As per the proposal that was submitted to fedora-devel,
createrepo_c
would not necessarily generate EL7-compatible repos by default due to the treatment of comps metadata anyway - this would be an even less disruptive than that as yum is perfectly capable of handling repos without sqlite metadata, it is merely preferred if present.
-
sqliterepo_c
could be split into a new package so that it could be dropped at some point in the future without breakingcreaterepo_c
's semantic versioning- Or maybe it makes sense to just remove entirely, now, as per the above points? Splitting the package off is just a conservative option.
Pulp currently does use createrepo_c
's sqlite metadata support, but we're going to drop it in the near future.
Originally posted by @dralley in #338 (comment)
What would be benefit of the split?
so that it could be dropped at some point in the future without breaking createrepo_c's semantic versioning
I think that was written before the point where you mentioned that we'd probably just do a 2.0 in a couple of years, though, and it wouldn't be a big deal.
I suggest to deliver the change with 2.0 version.
@j-mracek Do you want to have a deprecation warning on --database
before then, or just drop it.
Documented deprecation without warning is a good first step.