The `lr gpg list_keys` function crashes if called on an empty keyring
jrohel opened this issue · 3 comments
Error in line:
for (guint i = 0; i < keys->len - 1; ++i) {
keys->len is unsigned. For empty keyring keys->len == 0.
0 - 1 is max value for unsigned type.
@jrohel Hi, has this problem been solved? Is there any reproduction code?
has this problem been solved?
Yes, in this PR #277
Is there any reproduction code?
To reproduce the error, you need to call the lr gpg list_keys librepo API function where the home_dir parameter points to an empty directory. Or a directory containing an empty keyring.
The lr gpg list_keys function is used by the libdnf5 library and therefore the dnf5 application can be used to reproduce the error.
The older library libdnf (and thus the application dnf, microdnf, PackageKit, ...) does not use this function yet, it assumes that librepo uses GpgME and accesses the keyring directly via the GpgME library. So they cannot be used for reproduction.
A simple reproducer:
- use a repository with
repo_gpgcheck=1(e.g. google-chrome) - run dnf5 and import the keys
- delete the contents of the directory with the imported keys (the path to the imported keys for the root user
/var/cache/libdnf5/<repo_cache_dir>/pubring/) - run dnf5 again, this will call the
lr gpg list_keysfunction on an empty directory (contains 0 keys)