rraval/git-nomad

some git/config options can be useful to load (like credential.helper)

Closed this issue · 3 comments

dguibert commented

https://github.com/rraval/git-nomad/blame/096e0b5a9fb3caabf6bfb14bf0c0e75963517748/src/git_binary.rs#L27
unsetting HOME and XDG_CONFIG_HOME avoids to load ~/.config/git/config.

Every time I run git nomad sync it asks for my login/password. But credential helpers (cache, password-store or store) are configured in my git/config.

Maybe unwanted options could be filtered out with -c bad_option=.

rraval commented

Thanks for raising this issue.

The environment variable suppression dates to a much earlier design that had mandatory configuration and a git nomad init subcommand. All of this was overhauled in 0.4.0 and #5.

I think this code path can be dropped outright. Will fix and cut a new release.

rraval commented

@dguibert I've published v0.7.0 which should contain a fix for this issue. Give it a shot and re-open in case I've missed something.

Thanks again for reporting this.

  • 👍1
dguibert commented

thank you, working as expected.

  • 🎉1