Does not work with Circle CI
Opened this issue · 5 comments
The $TRAVIS_PULL_REQUEST env variable is hardcoded into the valid? method, so if you're building on a CI other than Travis the docs will never get pushed. Maybe we could check if the env variable exists and is false instead of just checking for the false value?
Ah, I see! Thanks for the heads up. I will fix this and come back to you as soon as I can.
I tried to manually set the flag to false in the Circle CI environment (as well as locally, on my machine) and the upload is apparently successful (I get a "Build # created successfully" message) but the docs never show up on Inch CI. Once I did it from a Travis build it worked immediately, so maybe there's something else that is making it only work for Travis builds?
This was intentional. I wanted to have a certain level of awareness which services publish to Inch CI ... We'll see if this was a good idea or not ... ❔
I just pushed CircleCI support and a new version of InchEx!
Ah, ok, I get it! I'll switch the project back to Circle CI again to test support for it in a few days then. Thanks!
No problem. I will leave this issue open for now.
Please report your findings!