rseng/rse-phenotype

TypeError appears to have broken the Generator?

Closed this issue · 4 comments

mwoodbri commented

I see the following in my browser's developer console when loading https://rseng.github.io/rse-phenotype/:

TypeError: "this.values is null"
    generateDatasets https://rseng.github.io/rse-phenotype/rse-phenotype.js:104
    render https://rseng.github.io/rse-phenotype/rse-phenotype.js:195
    mounted https://rseng.github.io/rse-phenotype/rse-phenotype.js:46
    VueJS 7
    <anonymous> https://rseng.github.io/rse-phenotype/rse-phenotype.js:11
vue.js:1897:15

This seems to make the Generator unusable for me (macOS + Safari/Firefox/Chrome). Reverting this change appears to fix it.

vsoch commented

That indeed is weird, the fix was working locally (and doesn't seem to be now). Could you try again now?

mwoodbri commented

What a super-speedy response! Working great now - I'll go ahead and link to you from our newsletter as originally planned :)

For reference: e381ff5. Many thanks.

vsoch commented

Awesome, thanks! And sorry about the bug!

mwoodbri commented

No worries. Should have said that this was all motivated by the thought that an RSE Phenotype is a prime candidate for inclusion in one's GitHub profile!

  • ❤️1