rsksmart/rLogin

WalletInfo dialog - bug - ignores rLogin's selected theme

Opened this issue · 2 comments

kazazor commented

When calling rLogin.showWalletInfo the modal that opens always show up using the default theme.
But if the theme was changed on rLogin before calling showWalletInfo, it's expected that the dialog will show in the new theme.

This is not the case, the dialog is shown always using the defaultTheme.

Reproduce it:

  1. Start rLogin with a default theme of dark mode
  2. Open rLogin
  3. Change the theme to light mode
  4. Connect to metamask
  5. Click a button that calls showWalletInfo
  6. Watch that the dialog is loaded with dark mode instead of light mode
jessgusclark commented

Info: This bug only exists one direction. Starting in light mode, switch to dark mode, open popup it is in dark mode.

kazazor commented

@jessgusclark I'm not sure regarding the directions. Cause in my case as I described above I'm starting with dark mode and not light mode.
I think it also has something to do with the defaultTheme we're using.