rsocket/rsocket-cpp

yarpl::enable_get_ref causes build break

phoad opened this issue · 1 comments

phoad commented

Build issues:

yarpl/include/yarpl/Refcounted.h:385:7: error: 'yarpl::enable_get_ref' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class enable_get_ref {
^
yarpl/include/yarpl/Refcounted.h:385:7: error: 'yarpl::enable_get_ref' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class enable_get_ref {

dymk commented

Hmmmm. Looks like in debug mode it needs virtual ~enable_get_ref() {}, similar to how debug mode adds a dummy virtual method to it?

What build config causes this error?