rstudio/tufte

formatR is required for a default tufte document

cderv opened this issue · 3 comments

cderv commented

We have tidy = TRUE as option in

knitr_options$opts_chunk$tidy = TRUE

This requires the formatR package which is not in import.

This is not a issue we've seen often because skeleton sets it to FALSE

knitr::opts_chunk$set(tidy = FALSE, cache.extra = packageVersion('tufte'))

I encountered this as a warning in rmarkdown tests
https://github.com/rstudio/rmarkdown/pull/1958/checks?check_run_id=1442968802#step:14:34
and it took me time to understand it came from here.

@yihui it is safe to add formatR to import, but a cleaner solution would be to set by default tidy option to FALSE. But it has been like that since the start (ea56b52 and 01a4f0a)

Why set to TRUE if FALSE in skeleton ?

Which solution do you prefer ?

cderv commented

In fact even with the default template, if formatR is not installed, we get the warning

Warning messages:
1: In block_exec(params) : Failed to tidy R code in chunk 'setup'. Reason:
Error in loadNamespace(name) : there is no package called 'formatR'

That is unfortunate. It will be fixed with one of the two solution above.

yihui commented

I'm okay with removing the setting, which means using the default tidy = FALSE. Feel free to commit to the master branch with a news item. Thanks!

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.