Move bench creation to `cli` instead from container script
Xieyt opened this issue · 1 comments
Xieyt commented
Currently, fm
utilizes Docker container script to create a bench (site). The process involves the container's entrypoint script, which creates the site using environment variables provided as input. We need to shift the bench creation process from the container's entrypoint script to the fm
cli logic.
Benefits:
- Help identify clearly why an app didn't install and give specific error to the user.
- Will make the cli more stable since all the main logic is controlled by the cli.
Actionable:
- Handle porting of
docker compose exec
logic for frappe containeruser-script.sh
. - Handle
create
command failure error by giving user concise and correct error information.