WebHooks method is deprecated; update to GitHub Apps.

Question

WebHooks method is deprecated; update to GitHub Apps.

Closed this issue 6 months ago · 5 comments

sarina commented 3 years ago

Hi,

The instructions say to use a webhook to configure:

You can generate a Slack incoming webhook token from here.

However this method is deprecated. This Action needs to be upgraded to use the suggested method.

Thanks!

Answer 1 · 2022-04-05T21:16:26.000Z

Hello,
I could replace it with chat.postMessage. What do you think?

Answer 2 · 2022-04-06T09:32:45.000Z

I think it might have more impact than documentation.
I use action-slack-notify with a Slack App but the webhook you obtain is tied to a channel.
So the SLACK_CHANNEL parameter won't be used anymore.

Note: As I'm just starting to use this action, I may have missed some way to configure it.

Answer 3 · 2022-04-06T13:36:00.000Z

Apologies for not adding what I did. I used a Slack app to do this integration. I guess I never even used this Action. https://github.com/openedx/.github/blob/master/.github/workflows/add-depr-ticket-to-depr-board.yml#L85-L92

Answer 4 · 2022-05-30T16:54:02.000Z

The instructions say to use a webhook to configure:

You can generate a Slack incoming webhook token from here.

However this method is deprecated. This Action needs to be upgraded to use the suggested method.

Agree that documentation should be updated to non-deprecated method. Slack Apps should be default moving forward.

However, I would prefer to keep the existing deprecated functionality in place until Slack actually removes it.

Answer 5 · 2022-05-31T15:09:11.000Z

However, I would prefer to keep the existing deprecated functionality in place until Slack actually removes it.

Why? I was creating a brand new integration and I strongly preferred to not use a functionality that would be soon deprecated and cause me to have to re-implement it. Why not at least have both instructions?