Unable to get SLACK_ICON or SLACK_ICON_EMOJI to work

[jmeridth]

SLACK_ICON

github action env vars

https://github.com/jmeridth?size=48 is a valid image

results

---

SLACK_ICON_EMOJI

github action env vars

results (I think this is a result of #89)

Both keep just showing the app icon.

What am I doing wrong?

Thank you for any assistance you can provide. Cheers.

[jmeridth]

The step in my github actions file

- name: Slack Notification
      uses: rtCamp/action-slack-notify@v2
      env:
        SLACK_CHANNEL: our-channel-name
        SLACK_COLOR: ${{ job.status }}
        SLACK_ICON_EMOJI: ${{ fromJSON('[":x:", ":white_check_mark:"]')[job.status == 'success'] }}
        SLACK_MESSAGE: "Deploy ${{ fromJSON('[\"FAILED\", \"SUCCEEDED\"]')[job.status == 'success'] }}"
        SLACK_TITLE: 'Application Deployment: Production Environment'
        SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}
        SLACK_FOOTER: 'Powered by our Terraform automated deploys'

[jmeridth]

@mrrobot47 snippet from my github action above, as requested. Cheers.

[iorys]

The step in my github actions file

- name: Slack Notification
      uses: rtCamp/action-slack-notify@v2
      env:
        SLACK_CHANNEL: our-channel-name
        SLACK_COLOR: ${{ job.status }}
        SLACK_ICON_EMOJI: ${{ fromJSON('[":x:", ":white_check_mark:"]')[job.status == 'success'] }}
        SLACK_MESSAGE: "Deploy ${{ fromJSON('[\"FAILED\", \"SUCCEEDED\"]')[job.status == 'success'] }}"
        SLACK_TITLE: 'Application Deployment: Production Environment'
        SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}
        SLACK_FOOTER: 'Powered by our Terraform automated deploys'

Nice example thanks :). I have changed icon directly in slack app, so finally looks much nicer.
https://slack.com/intl/en-lv/help/articles/204379773-Upload-a-Slack-icon

[jmeridth]

@iorys nice. That is definitely an option for a default icon but as you can see I want it to be dynamic based on deployment success ✅ or failure ❌ . Hoping @mrrobot47 has a solution and I'm just doing something silly and easily fixable.

[jmeridth]

@mrrobot47 or another contributor, any ideas?

[jmeridth]

Ok, so I completely removed SLACK_ICON and SLACK_ICON_EMOJI from my payload and I don't even get the default icon as stated in the README

Either this action needs to be updated or my app doesn't have icon editing permissions. Looking. Will test locally and possibly submit PR. Otherwise I'll use a different action. Cheers.

[jmeridth]

Does this matter?

from here

[mrrobot47]

Apologies for the delayed response.

Does this matter?

@jmeridth yes this matters. Unfortunately, this seems to be the issue with the icon not working.
I am closing this issue for now as I am going to put your PR on hold for now. The reason being, the icon is still working with incoming webhooks created before this rule was enforced. There are many users who already have the webhook configured which works with this option. Until it is deprecated completely I would not like to remove the feature.

I will be emailing slack support to verify the status of usage of slack icon in the previously created webhooks and an ETA on when it will be deprecated/removed completely. According to the response, we will gradually sunset the support of slack icon from the action and merge your PR.

Thanks for your contribution 🙏