Utilize site icon customizer option for PWA icon
Closed this issue · 3 comments
pradeep910 commented
Current code asks for separate /assets/img/icon-%2$sx%2$s.png inside theme. We can utilize site icon itself to generate app icon sizes.
Goal is to make manifest file ready for all WordPress sites, and with just site icon add-to-homescreen feature can be enabled.
- Use site icon to generate PWA app icon sizes - https://github.com/rtCamp/pwa-extension/blob/master/class-pwa-manifest.php#L32-L35
- Add filter for App Icon URLs so that we can filter Icon URLs if needed.
pradeep910 commented
@deepaklalwani97 Please work on this and add filter for icons.
- Add filter for App Icon URLs so that we can filter Icon URLs if needed.
deepaklalwani97 commented
@pradeep910 I have added filter for app icon URLs in this PR #23, please review
deepaklalwani97 commented
@pradeep910 We can change icon URL using the web_app_manifest filter. Let me know if we still need this refer #23 (comment). Otherwise, we can close this