rtfeldman/node-test-runner

Update elm-format to 0.8.4

Closed this issue · 13 comments

harrysarson commented

Instructions:

  1. Clone repo
  2. npm install
  3. npm install -D elm-format@latest
  4. elm-format . --yes
  5. Commit changes
  6. Pull request!
Apoorve73 commented

Is that much to be done?

harrysarson commented

It should be really straightforward! But I expect there will be some small formatting diff because harrysarson#159 errored in CI.

Apoorve73 commented

I will try that once!

harrysarson commented

Remving help wanted to give @Apoorve73 time to have a go :)

g-belmonte commented

@Apoorve73 are you still on it?
@harrysarson I have already done this locally. Gimme the green sign and the PR is open :)

harrysarson commented

Give @Apoorve73 24 hours, otherwise go for it :)

Apoorve73 commented

@harrysarson I have made a PR, as referenced above. Kindly review that. Also, I found that, recently Hacktoberfest's guidelines were updated. Please have a look here, before merging PR or closing the issue. :)

harrysarson commented

Do I add the label now or when I merge?

g-belmonte commented

As far as I know, you need to add the "hacktoberfest" topic to the repository :)

  • 👍1
Apoorve73 commented

As far as I know, you need to add the "hacktoberfest" topic to the repository :)

Also, while merging the PR, you will also have to add a label "hacktoberfest-accepted" to the PR.

g-belmonte commented

If you have the topic on the repo, and you merge anything, it counts already. The "hacktoberfest-accepted" label is just if you want to accept it, but not merge it right away (since it may be merged after the hacktober period).
Here some more info: https://hacktoberfest.digitalocean.com/hacktoberfest-update 😁
--- edit
You don't actually need the topic on the repo if you label the PR with the hacktoberfest-accepted
image

Apoorve73 commented

Oops! @g-belmonte , You are right. :)

g-belmonte commented

@harrysarson since the last PR was closed, I opened a new one.

  • 👍1