rtomayko/rack-cache

Bug: Version 1.3 forward breaks Ruby 1.8.7 systems using latest Rails 3 (specifically 3.2.22)

oldfartdeveloper opened this issue · 2 comments

oldfartdeveloper commented

This was tedious for us to figure out. Changing the requirement for what ruby you are requiring certainly breaks backwards compatibility, which, according to semantic versioning means that this should have been a major revision release, not a minor one.

I.e.

  • This release 1.3.0 should have been 2.0.0.
  • 1.4.0 should have been 2.1.0.
  • 1.5.0 should have been 2.2.0.

Is it too late to modify the revision levels thusly so that other (unfortunately) 1.8.7 shops don't have this surprise when they do their next deployment? Or, if the latest code is still compatible w/ Ruby 1.8.7 (or can be easily modified), can Ruby 1.8.7 be restored to be an acceptable ruby version?

btalbot commented

Yeah, 7 releases in a couple days with some of them breaking major installations is a big issue. I'm locking my version to 1.2 until things settle down.

grosser commented

merged a lot of stale PRs with nice patches and made every change a new bump so you can pick and choose what you want, there should be nothing major new coming, so use latest :)

1.3 breaks only because bundler does not consider ruby versions when installing.
semver says 'MAJOR MUST be incremented if any backwards incompatible changes are introduced to the public API' public api did not change at all, that's why I chose minor.

making it major would also have meant nobody on 3.2 could get the new patches which is also bad ...

gem 'rack-cache', '~> 1.2.0' should fix the issue ...