Do we still support 1.8.7 and 1.9.2?
Closed this issue · 4 comments
RDiscount doesn't work in 1.9.2: https://travis-ci.org/rtomayko/tilt/jobs/5048025
We're using 1.9-specific syntax:
tilt/test/tilt_markdown_test.rb
Line 110 in be40174
I think we should support 1.9.2 on as a "best effort matter" (no Travis, but we'll accept patches).
It doesn't seem hard to support 1.8.7, so we might as well do it.
Thoughts?
Also, Travis doesn't like JRuby + C-extensions: https://travis-ci.org/rtomayko/tilt/jobs/4722050
@rkh: How can we fix that?
There is a hack to enable them, but it doesn't work well. Considering that JRuby has deprecated C extensions and is going to remove that feature in the future, how about simply not running these on JRuby?
It's a bit tricky now because RDiscount is a development dependency in the gemspec. We could remove it as a development dependency and just have it in the Gemfile though. Not sure if anyone actually use gemspec's development dependencies.
Now that our Travis is on the right track I think we can keep support for this. Let's rather re-visit later.