Fix for "release => ''" problem in apt::source
Closed this issue · 1 comments
jordansissel commented
Looks like the latest(?) version of the puppetlabs/apt module doesn't approve of an empty 'release' but is happy if repos is empty:
The error:
Error: lsbdistcodename fact not available: release parameter required at /home/jls/projects/demo.lo
gstash.net/modules/apt/manifests/source.pp:25 on node ds4172.dreamservers.com
Version info:
% grep version modules/{apt,jenkins}/Modulefile
modules/apt/Modulefile:version '0.0.4'
modules/jenkins/Modulefile:version '0.2.3'
Here's the workaround I applied to make the correct sources.list file generated with apt::source from your jenkins module
It's not a pull request because I haven't forked this, just imported into my own repo.
--- a/modules/jenkins/manifests/repo/debian.pp
+++ b/modules/jenkins/manifests/repo/debian.pp
@@ -1,8 +1,8 @@
class jenkins::repo::debian {
apt::source { 'jenkins':
location => 'http://pkg.jenkins-ci.org/debian',
- release => '',
- repos => 'binary/',
+ release => 'binary/',
+ repos => '',
key => 'D50582E6',
key_source => 'http://pkg.jenkins-ci.org/debian/jenkins-ci.org.key',
include_src => false,