rubocop/rubocop-rspec

RuboCop::RSpec::Language::NodePattern was removed

bquorning opened this issue · 4 comments

bquorning commented

Address rubocop-rspec_rails still having a dependency on RuboCop::RSpec::Language::NodePattern which we removed in d841fe4. We should probably fix this before next release.

pirj commented

We would also need to bump the dependency to the fixed rubocop-rspec_rails version?

bquorning commented

We (rubocop-rspec) don’t have a runtime dependency on rubocop-rspec_rails anymore.

It seems that the issue in rubocop-rspec_rails is easy enough to fix – we can just remove the line with the require. But it needs to be on a version of rubocop-rspec which includes d841fe4, which has not been released yet.

We can probably make a v3.0.0.pre quite soon, which would make it possible to at least open a PR on rubocop-rspec_rails.

Update: Here’s the PR.

bquorning commented

I think rubocop/rubocop-rspec_rails#30 proves this issue is easily solvable. I’m closing this so it doesn’t block v3.0.