ruby-hyperloop/hyper-react

event `onChange` does not map to `on_change` when attaching to ruby component

catmando opened this issue · 0 comments

if you say for example: MyRubyComponent().on(:change) then MyRubyComponent will receive a onChange param. But if you say MyRubyComponent().on(:foo_bar) then MyRubyComponent will receive a on_foo_bar param.

See

def merge_event_prop!(event_name, &block)

For why.

The reason this is done is that MyRubyComponent can pass all_other_params on to components nested within it, and the event names will follow along.

Perhaps rethinking the entire param interface between ruby and native components could yield a more consistent solution.