ruby-passkeys/devise-passkeys

Remove unused `maximum_passkeys_per_user`; not the gem's concern

Closed this issue · 2 comments

tcannonfodder commented

The :maximum_passkeys_per_user attribute is legacy code from the early experiments in the gem (see: https://github.com/ruby-passkeys/devise-passkeys/blob/main/lib/devise/passkeys/passkey_issuer.rb#L38).

And validations/limits on the number of passkeys that can be created should be handled by the app itself. This keeps the gem focused, reduces our maintenance overhead, and gives implementors control over the exact behavior

johalloran01 commented

@tcannonfodder I can take this issue when I return home.

  • 👍1
johalloran01 commented

Created a pull request for this issue: #41