JRuby support

Question

JRuby support

headius opened this issue 2 years ago · 12 comments

JRuby provides its own extension for the date library, and this will need to be incorporated into the released gem. We will do the work on this.

Answer 1 · 2022-11-23T22:35:22.000Z

We have an immediate need for a no-op date gem due to it being a transitive dependency of many libraries, including time 0.2.0.

Could we push an empty -java platform gem for the most recent date release? We will prioritize dealing with this appropriately after the US Thanksgiving holiday.

Answer 2 · 2022-11-23T22:36:28.000Z

@hsbt Sorry to always ping you but I can't tell who maintains this library. Can you help us get an empty date gem released, so JRuby 9.4 users will be able to run latest net-ftp and time gems (at least)?

Answer 3 · 2022-11-24T06:47:16.000Z

@headius 👋

I'm not sure what's mean no-op on date gem. In my understanding, spec.files and spec.extension are empty both. Can you submit a PoC for this?

Answer 4 · 2022-12-09T03:29:41.000Z

@hsbt Yes that is basically it; it would satisfy the gem dependency but not install any of the extension code.

We may be able to move our date implementation into this gem at some point but it is rather entwined with JRuby core right now.

Answer 5 · 2022-12-09T04:23:31.000Z

An alternative would be releasing a time gem with -java that does not depend on date.

Answer 6 · 2022-12-09T04:48:29.000Z

@hsbt I have pushed #81 to stub out the gem on JRuby. Can we get a 3.3.1 release with this soon (ASAP if possible)?

Answer 7 · 2022-12-09T04:49:39.000Z

I assume this is related to ruby/net-imap#84 (logged there for others' benefit, but may be a wontfix)

Answer 8 · 2022-12-09T04:50:33.000Z

@chadlwilson Yeah it's the same issue. The no-op gem should fix this everywhere for now.

Answer 9 · 2022-12-09T07:58:21.000Z

@chadlwilson @headius I released date-3.3.1 and date-3.3.1-java that is empty package. Can you try it?

Answer 10 · 2022-12-09T08:30:01.000Z

@hsbt It looks like it's working!

[] jruby $ gem install time
Fetching date-3.3.1-java.gem
Fetching time-0.2.0.gem
Successfully installed date-3.3.1-java
Successfully installed time-0.2.0
Parsing documentation for date-3.3.1-java
Installing ri documentation for date-3.3.1-java
Parsing documentation for time-0.2.0
Installing ri documentation for time-0.2.0
Done installing documentation for date, time after 0 seconds
2 gems installed

Answer 11 · 2022-12-09T11:09:49.000Z

Thanks, seems to be working fine (at least for gem installs) - we don't use activemailer or net-imap from rails so can't validate the wider functionality of date equivalents under JRuby, but this is good so far - thanks!

Answer 12 · 2022-12-09T11:59:23.000Z

Part of us moving the JRuby code into the gem will be getting all tests passing. It's a tall order but that's the plan and hopefully we can do it in the next few months.