No bool type

Question

No bool type

eregon opened this issue a year ago · 7 comments

/home/eregon/.rubies/ruby-3.2.2/lib/ruby/3.2.0/fiddle/cparser.rb:247:in `parse_ctype': unknown type: bool (Fiddle::DLError)
	from /home/eregon/.rubies/ruby-3.2.2/lib/ruby/3.2.0/fiddle/cparser.rb:117:in `parse_signature'
	from /home/eregon/.rubies/ruby-3.2.2/lib/ruby/3.2.0/fiddle/import.rb:168:in `extern'

for extern "bool foo(void *buffer)" with extend Fiddle::Importer.

Maybe a workaround is to use typealias, but not sure what would be the correct type then.

Answer 1 · 2023-07-03T07:45:15.000Z

Good catch.
I've implemented it.

Answer 2 · 2023-07-30T08:12:43.000Z

Thanks!
Ideally extern "bool foo(void *buffer)" would return Ruby true/false, not 1/0 (which are both truthy in Ruby).
Do you think Fiddle could handle that?

Answer 3 · 2023-07-30T21:21:53.000Z

Ah, then we should not implement bool as an alias.

Answer 4 · 2023-10-27T10:06:27.000Z

@kou Should we revert bc6c66b maybe? Because if bool is then implemented properly to use Ruby true/false instead of 1/0 then it would be incompatible when that changes.

Answer 5 · 2023-10-27T20:08:59.000Z

Is it for Ruby 3.3.0?
If I can implement bool <-> Ruby's true/false soon, we don't need to revert the commit, right?

Answer 6 · 2023-10-27T21:13:56.000Z

Implemented.

Answer 7 · 2023-10-29T10:22:11.000Z

Thanks!
Yeah, I just wanted to avoid the half-done support for boolean to get in a Fiddle release, or if it did for as short as possible.