Improve banner expiration validations and form
Closed this issue · 2 comments
What type(s) of user does this feature affect?
- admins
Description
#5800 added expiration times to banners (/banners
)
After testing the feature we want to make some improvements to it.
- add server side (and client if possible with basic html) to validate that expiry cannot be in the past.
- validate the banner actually has content, otherwise a banner will be active but nothing will be shown
- when a banner expires set it to inactive (this might be complicated with the added validations but explore it)
- Rename values as shown below
How to access the QA site
Login Details:
Link to QA site
Login Emails:
- volunteer1@example.com view site as a volunteer
- supervisor1@example.com view site as a supervisor
- casa_admin1@example.com view site as an admin
- all_casa_admin1@example.com view site as an all casa admin
- go to
/all_casa_admins/sign_in
- go to
password for all users: 12345678
Questions? Join Slack!
We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.
This issue has been inactive for 248 hours (10.33 days) and will be unassigned after 112 more hours (4.67 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 368 hours (15.33 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.