rubyforgood/playtime

Fix spacing on wishlist item partials

Closed this issue · 7 comments

leesharma commented

The Issue

The spacing gets wonky after the staff message field when the staff message is missing. When the staff message is there, it gets weird after the price field.

without a staff message
with a staff message

Reproducing the issue

Both of these can be seen at https://project-playtime-staging.herokuapp.com/. You can reproduce locally by adding items with and without a long staff message.

Task

In short, make this look reasonable. The staff message, the number/priority/price, and the management tools should all be on separate lines. It might make sense to hide the "Staff Message" label when the staff message is missing; I'll leave that to your artistic discretion.

The partial can be found at app/views/wishlist_items/_wishlist_item.html.erb.

alanunruh commented

Hey @leesharma - I'd be happy to make the edits you've suggested!

leesharma commented

@alanunruh Awesome! 👍

jtruong2 commented

Has this been resolved? If not, I'll be more than happy to work on it.

alanunruh commented

Hey @jtruong2 - yes I’m still working on this. I’ve had some things pop up over the past week (sorry). I’ll wrap up what I’ve worked on and submit a solution shortly.

jtruong2 commented

@alanunruh Sounds good! 👌

alanunruh commented

@leesharma - So sorry for the delay! I've becoming increasingly busy and thus have not been able to complete this pull request. I'll withdraw as I know I'm impeding process.

@jtruong2 - Please feel free to take this.

I'll keep my eyes on this project if time permits as I'd love to contribute. All the best!!

UJKhokhar commented

@leesharma I opened a PR for this