rubymem/ruby-mem-advisory-db

celluloid's leaky version misrepresented?

Opened this issue · 0 comments

Hey,

I noticed that celluloid's leaky versions are defined like this:

---
gem: celluloid
url: https://github.com/celluloid/celluloid/issues/670
title: Memory Leak using Celluloid::Future
date: 2015-08-31
description: |
  The Celluloid::Group::Spawner appears to never clean up the completed Threads
  that it creates.
leaky_versions:
  - "> 0.16.0, < 0.17.2"
patched_versions:
  - ">= 0.17.3"

Shouldn't leaky_versions say this?

leaky_versions:
  - "> 0.16.0, < 0.17.2"
patched_versions:
  - ">= 0.17.2"

The patch made it into v0.17.2 (see celluloid/celluloid@5725fee)

It seems that it is misreporting a leaky gem when you are using 0.17.2:

$ bundle leak
Name: celluloid
Version: 0.17.2
URL: https://github.com/celluloid/celluloid/issues/670
Title: Memory Leak using Celluloid::Future
Solution: upgrade to >= 0.17.3

Leaks found!