ruifigueira/playwright-crx

Unable to install playwright-crx through pnpm

molvqingtai opened this issue · 4 comments

molvqingtai commented

When I run pnpm i playwright-crx, the installation failed and no file was found: playwright/packages/playwright/bundles/babel

This seems to be used because the local file: path is used in package.json

ruifigueira commented

You're right, with pnpm it's not working. With npm it is working, that's why I never noticed that issue.

I'm using those local playwright bundles dependencies to avoid declaring all their transitive dependencies explicitly. Can you use npm instead to install it?

ducan-ne commented

@ruifigueira use npm works and it is fine for testing, but do you have plan to make pnpm works? For production I (and people) usually use pnpm

ruifigueira commented

8f06b95 should fix the issue. You can try it:

git clone git@github.com:ruifigueira/playwright-crx.git
npm ci
npm build
npm pack

This will generate a playwright-crx-0.6.0-next.tgz.

Then create a new temp folder, copy the playwright-crx-0.6.0-next.tgz. file there and run:

pnpm add playwright-crx-0.6.0-next.tgz
ruifigueira commented

I released playwright-crx@0.6.0, it now works well with pnpm.