ruifm/gitlinker.nvim

Add patterns in default callbacks

Opened this issue · 2 comments

Sayrus commented

Is your feature request related to a problem? Please describe.

Many companies have custom domains for their git hosting. These domains often start by the forge name (gitlab., github., bitbucket.) and having mixed domains/forge is very rare (GitHub instance on gitlab.mycompany.tld for instance)

Describe the solution you'd like

After using GitLinker for a while, I only now discovered that it already supports host with wildcards. Since false-positive are very rare and can be overridden with the TLD anyway, I think that providing patterns by default might be a good default. This reduces entry-cost for user and will make GitLinker work with most enterprise forges by default.

Here are some pattern I have observed:

  • bitbucket.*: BitBucket
  • gitlab.*: Gitlab
  • ghe.*: GitHub (short for GitHub Enterprise)
  • github.*: GitHub

Describe alternatives you've considered

If adding patterns to the defaults are not something you want on GitLinker, can we add a short documentation to ensure users know they are able to use wildcards?

Additional context

N/A, thanks for this awesome project !

linrongbin16 commented

I want the same function, regex pattern is quite useful!