[BUG] Incompatibility between Settings Extender and libWrapper in V9
Closed this issue · 4 comments
I read the posting info, and realize this is likely to be a Settings extender issue, but I'm ignorant in programming or the meaning of the error messages, so I'm cross-posting this on the Settings Extender git as well (https://gitlab.com/foundry-azzurite/settings-extender/-/issues/6)
Both Settings Extender 1.1.6+0.8.6 and libWrapper 1.11.0.1 are individually marked as compatible with V9, and when enabled individually, both seem to operate with no issue.
However, when both are enabled (even in a clean world with no other modules) Foundry's Configure Settings window will not open, and the following error is logged in the console when you try:
Disabling either module removes both the issue and the error.
Settings extender 1.1.6+0.8.6 seems to be out-of-date, with the newest version being 1.1.7+9. Did you incorrectly state the version? 1.1.6+0.8.6 does not seem to report compatibility with Foundry v9.
I can't reproduce this with the updated version (1.1.7+9) and libWrapper 1.11.0.1.
Looking at the changes between 1.1.6+0.8.6 and 1.1.7+9 (which add v9 compatibility), it seems to address this exact error. I suspect you are using the old (non-v9-compatible) version by mistake.
For whatever it is worth, libWrapper doesn't seem to be involved at all in the error message itself, which is the text in red. It only comes into play when Foundry is reporting the error, the text in grey inside the red background.
As such, I'd agree with you, this is almost certainly a Settings Extender issue, rather than libWrapper.
Hrm....I reported the version that I have installed after updating, and 1.1.6+0.8.6 seems the be the furthest it will update within Foundry. It does appear to me to be V9-compatible, based on the lack of compatibility warning tags in both the Add-on Modules tab in setup:
and the Manage Modules window in a world:
Interestingly enough, I just checked the module.json in the Setting Extender module folder in data/modules on my disk, and it does show as 1.1.7+9, but still shows up at 1.1.6+0.8.6 in Foundry.
so I'll go bark up Azzurite's tree a bit more.
I grabbed 1.1.7+9 just fine using the UI, and looking at the changes between 1.1.6+0.8.6 and 1.1.7+9, it is clearly the change that adds v9 compatibility to the manifest, and seems to address this exact error you were seeing. I also can't reproduce this failure except by downgrading to 1.1.6+0.8.6, in which case I see the exact issue you reported (and it is not because of libWrapper).
I suggest restarting the Foundry server, something might've gone wrong and it is using the pre-update version for some reason. Restarting it should force the server to reload from disk. Can also try to unninstall + reinstall the module as well.
Anyway, at this point I am essentially convinced this is not a libWrapper issue, so will close this report. Feel free to re-open if it turns out I am wrong.