Random repeated keystrokes
c64-dev opened this issue · 13 comments
I am having some very annoying issues with random repeated keystrokes when using the C64 keyboard+Pico Pi connected to a Raspberry Pi 3b+.
What is happening is that quite often keystrokes are being repeated when I am simply trying to type something. Instead for example ls /library I may get lss /liibrarry
This is happening on all keys and in any mode (prompt only, GUI etc). Up until recently I was using a Keyrah which never had this issue. Maybe the script is not filtering all ghost keystrokes properly?
Would changing the scanning intervals and/or the ghost values fix this issue?
Try increasing #define KB_DEBOUNCE_US 5000 and let me know what value works. Something in the range of 5000-50000 microseconds is expected.
I am downloading the tools to be able to compile the scripts as we speak. Will revert.
Another thing that I noticed is that the arrow keys always do a double press when pressed once initially, but then they behave properly (ie one key press = one response)
Try 100000 (100ms) too. Change to uint16_t debounce for that. My return key acts like you describe on occasion. I can always feel the bounce when it does. 100ms filters mine, but is getting close to human limits. Since you have a more affected keyboard, I'd like to know how low you can go.
I checked in a possible fix for your always crsr key repeat. And a change to 100ms debounce.
Thanks for the quick response.
I tested the keyboard connected to my Mac and I see an improvement.
The always repeated arrow keys seems to be fixed now, ,however there are still some repeated characters when typing. Would it make sense to try and increase the debounce even further?
Update: I managed to fix the randomly repeated characters by increasing the KB_SCAN_INTERVAL_US to 1000.
I will run more tests later today with the keyboard connected to the Raspberry but so far it looks really good.
1639516 changes the debounce algorithm. This filters bounces on the key release instead of key press. Seriously. It's fantastic.
Excellent! I didn't have the time to properly go through the code, but at first glace it looks very promising indeed. I think we can safely close this issue for now.
As a quick note, I think my issues with repeated keys partly come from the fact that I am using the keyboard with an RPi 3B+. When using the keyboard connected to my MacBook Pro I don't get any repeated keys, but when I connect it to the Pi I immediately see repeated characters. Could it be that the Pi is reading the USB port differently than the Mac?
I haven't had the chance to try out the new algo yet, so I will revert.
So unfortunately it seems that the double presses continue.
When the keyboard is connected to my Mac it seems to work fine, both with the old and new algorithm.
However, when connected to my Pi I constantly get random bounces.
I tried a Pi 3B+ and couldn't reproduce the problem.
This is very interesting. I also have been using a Pi 3B+. Working with the assumption that any two 3b+'s and the Picos themselves are pretty much identical, that leaves the keyboard itself and/or the cabling as the possible culprit.
To test out that theory, I just realised that I also have a Pi Zero kicking about, which I could run with the keyboard to see how it will behave.
The question then becomes why would this behaviour not be exhibited when using the Keyrah that I had been running up until recently.
Working on the Pi in the last few days I've noticed something very interesting.
It seems that the double characters are occuring every about 2-3 seconds. For example, if I type the word 'keyboard' repeatedly in my usual typing speed, the double characters will occur mostly on the same letter ('o' in this case)
So, it will look something like this: keybooard keybooard keybooard keyboaard etc
The double characters are not happening only if I type very slowly, which leads me to suspect the polling rate of the key presses.
There are now a couple defines for TinyUSB which may help, but I haven't tested because I can't reproduce this.
PICO_RP2040_USB_DEVICE_ENUMERATION_FIX=1
PICO_RP2040_USB_DEVICE_UFRAME_FIX=1