runabol/piper

Job.status webhooks don't notify of STARTED status

Closed this issue · 2 comments

I've started using Webhooks (thanks a lot for the updated documentation btw) but have encountered the following issue:
I get notified of CREATED and COMPLETED events, but not of STARTED ones.
I believe there is a bug on this line, which publishes the event before changing the status. Is this it or am I understanding incorrectly?
Also the notification of the CREATED status seems unnecessary, we already get it on the response to the create job request.

Yes, that totally looks like a silly bug.

On the CREATED though it might be useful if you want to notify a 3rd party application.

d5be235 fixed it, thanks!