thumbsup and thumbsdown are no longer valid emoji reactions in GitHub
Opened this issue · 0 comments
senilio commented
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
- If you are interested in working on this issue or have submitted a pull request, please leave a comment.
Overview of the Issue
While investigating why emoji reaction "thumbsup" wasn't working on GitHub, I found via the GitHub API response that it's no longer a valid value. The thumbsup/down reactions on GitHub have been replaced with +1 and -1.
Reproduction Steps
While using Atlantis with GitHub, set the ATLANTIS_EMOJI_REACTION environment variable to "thumbsup" and see that reactions isn't working as described in the documentation.
Logs
"msg":"Unable to react to comment, error: POST https://api.github.com/repos/myorg/myrepo/issues/comments/1234567890/reactions: 422 Invalid request.\n\nthumbsup is not a member of [\"+1\", \"-1\", \"laugh\", \"confused\", \"heart\", \"hooray\", \"rocket\", \"eyes\"].
Environment details
Atlantis version 0.28.5
Additional Context
As I can't verify if Azure DevOps or GitLab also supports the "+1" and "-1" reactions, I created an issue instead of updating the docs in a PR.