rundeck/terraform-provider-rundeck

Ideompotency fails

moosilauke18 opened this issue · 3 comments

Changing decription to description to correctly work causes ideompotency test to fail. The test has been changed in this to work, however we should fix the issue on the backend to allow the test to pass.

https://github.com/terraform-providers/terraform-provider-rundeck/pull/44

--- FAIL: TestAccJob_Idempotency (0.34s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: rundeck_job.test
          allow_concurrent_executions:         "false" => "false"
          command.#:                           "1" => "1"
          command.0.description:               "" => ""
          command.0.inline_script:             "" => ""
          command.0.job.#:                     "0" => "0"
          command.0.node_step_plugin.#:        "0" => "0"
          command.0.script_file:               "" => ""
          command.0.script_file_args:          "" => ""
          command.0.shell_command:             "echo hello" => "echo hello"
          command.0.step_plugin.#:             "0" => "0"
          command_ordering_strategy:           "node-first" => "node-first"
          continue_on_error:                   "false" => "false"
          description:                         "Testing idempotency" => "Testing idempotency"
          execution_enabled:                   "false" => "false"
          group_name:                          "" => ""
          id:                                  "8a34dc35-31a2-49a4-bc92-ac5addc76551" => "8a34dc35-31a2-49a4-bc92-ac5addc76551"
          log_level:                           "INFO" => "INFO"
          max_thread_count:                    "1" => "1"
          name:                                "idempotency-test" => "idempotency-test"
          node_filter_exclude_precedence:      "false" => "false"
          node_filter_query:                   "" => ""
          notification.#:                      "1" => "1"
          notification.0.email.#:              "1" => "1"
          notification.0.email.0.attach_log:   "false" => "false"
          notification.0.email.0.recipients.#: "1" => "1"
          notification.0.email.0.recipients.0: "foo@foo.bar" => "foo@foo.bar"
          notification.0.email.0.subject:      "" => ""
          notification.0.plugin.#:             "0" => "0"
          notification.0.type:                 "on_success" => "on_success"
          notification.0.webhook_urls.#:       "1" => "1"
          notification.0.webhook_urls.0:       "http://localhost/testing" => "http://localhost/testing"
          option.#:                            "1" => "1"
          option.0.allow_multiple_values:      "false" => "false"
          option.0.default_value:              "2" => "2"
          option.0.description:                "" => ""
          option.0.exposed_to_scripts:         "false" => "false"
          option.0.multi_value_delimiter:      "" => ""
          option.0.name:                       "instance_count" => "instance_count"
          option.0.obscure_input:              "false" => "false"
          option.0.require_predefined_choice:  "true" => "true"
          option.0.required:                   "true" => "true"
          option.0.validation_regex:           "" => ""
          option.0.value_choices.#:            "9" => "1"
          option.0.value_choices.0:            "1" => "1,2,3,4,5,6,7,8,9"
          option.0.value_choices.1:            "2" => ""
          option.0.value_choices.2:            "3" => ""
          option.0.value_choices.3:            "4" => ""
          option.0.value_choices.4:            "5" => ""
          option.0.value_choices.5:            "6" => ""
          option.0.value_choices.6:            "7" => ""
          option.0.value_choices.7:            "8" => ""
          option.0.value_choices.8:            "9" => ""
          option.0.value_choices_url:          "" => ""
          preserve_options_order:              "true" => "true"
          project_name:                        "terraform-acc-test-job-node-filter" => "terraform-acc-test-job-node-filter"
          rank_attribute:                      "" => ""
          rank_order:                          "ascending" => "ascending"
          schedule_enabled:                    "true" => "true"

for me also everytime doing, plan and apply it must change exposed to scripts value for options from false to true making an update to any module takes 15 minutes updating ~2000 jobs and sometimes it just fails due to connection reset errors while applying this huge change.

sekot commented

same for me with exposed to scripts :(

Please try to recreate this issue on the current Terraform and provider version. If you still have trouble open a new issue with steps to reproduce please.