removeLinkTag should replace all occurences of the css chunk
m5nv opened this issue · 4 comments
I hit on this while trying to get css preload to work in chrome and load normally in other browsers as suggested in a comment at SO.
The bug can be traced to this line.
The solution is to pass 'gi' parameter to RegExp object to find and 'remove' all occurrences of the chunk that needs to be inlined.
I fixed it locally and works for me. Cheers!
Yes, we should. But seems that i is unnecessary in this case. 🤔️ Did I miss something?
Yes, we should. But seems that
iis unnecessary in this case. thinking Did I miss something?
Doesn't hurt. Some folks like to use weird case for their tags. The html spec allows tag names and attribute names to be case-insensitive (at least the browsers don't seem to have issue with mixed case).
HTH.
Yes, we should. But seems that
iis unnecessary in this case. thinking Did I miss something?Doesn't hurt. Some folks like to use weird case for their tags. The html spec allows tag names and attribute names to be case-insensitive (at least the browsers don't seem to have issue with mixed case).
HTH.
@runjuu Any plans on doing a release with the fix any time soon? Thanks!