ruslashev/elfcat

Padding zeroes between code and data are highlighted in both code and data

PennRobotics opened this issue · 1 comments

Issue

Most of the padding zeroes are unhighlighted, since they occur between two span tags with different highlighting properties. The zeroes between code and data in the LOAD segment are highlighted, since one span tag with highlighting properties (bin_segment#) contains the span tags for code and for data.

Reproducing

In Chrome, with the current Hello World example, highlighting the data string shows three leading zeroes (null characters) highlighted as part of the data section.

Suggested fix

Remove/change highlighting from the bin_segment# span containing multiple child span tags. Add highlighting to the child span tags, leaving the zeroes either unhighlighted or highlighted differently than the surrounding sections, so users do not mistakenly believe these characters are part of either surrounding section.

Thanks. Yes, I see that now. Will fix.