Request params do not work in Python 3.3

[jacobSingh]

binary_params is fine for POST, but won't work for GET.

When you add them, urllib makes it a POST request.

[ZEDGR]

If you want try my fork because I think @russ- is not maintain this project anymore.

[jacobSingh]

Cool. I was using the async one which also works but the example doesn't... Async may be preferred ultimately since I'm pulling huge datasets down, but not sure it matters much. Have you thought of consolidating the two projects? Best, J

…

On Sat, Nov 26, 2016 at 7:09 PM, ZED ***@***.***> wrote: If you want try my fork <https://github.com/ZEDGR/pychal/> because I think @russ- <https://github.com/russ-> is not maintain this project anymore. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/russ-/pychallonge/issues/12#issuecomment-263063977>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHchlH_AgR2kiWIWOKPGAXCebIdULvMks5rCDacgaJpZM4K8y2p> .

-- +919971876580 twitter: @jacobSingh ( http://twitter.com/#!/JacobSingh ) web: http://www.jacobsingh.name Skype: pajamadesign gTalk: jacobsingh@gmail.com

[ZEDGR]

You mean my fork and this project? They are the same I am just trying to maintain the existing library if you look at my repo. I have made the fork because this repo is abandoned in my opinion. I have also upload my fork to Python Package Index. About the async I will look into it in the near future.

[jacobSingh]

Yeah, I meant consolidate with the async package and get the folks at challonge to make that the official. I'm pulling thousands of matches real-time, so async makes more sense in this case. Best J

…

On Nov 28, 2016 5:51 PM, "ZED" ***@***.***> wrote: You mean my fork and this project? They are the same I am just trying to maintain the existing library if you look at my repo. I have made the fork because this repo is abandoned in my opinion. I have also upload my fork to Python Package Index. About the async I will look into it in the near future. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/russ-/pychallonge/issues/12#issuecomment-263257867>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHchrI4Y9WKvBtjp83b3TPHPEdo-Mntks5rCsdhgaJpZM4K8y2p> .

[fp12]

Do you mean my async challonge lib (which is a fork of this one?) ? :)

[jacobSingh]

Yep, that's the one. Btw, the readme needs an update. I can roll one. The quick start won't actually work because you aren't awaiting anything. Best, J

…

On Sun, Dec 4, 2016 at 10:33 PM, fp12 ***@***.***> wrote: Do you mean my async challonge lib <https://github.com/fp12/pychallonge_async> (which is a fork of this one?) ? :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/russ-/pychallonge/issues/12#issuecomment-264715983>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHchr1ilxRxAVuwRAxGlW3AA2E_phwDks5rEvJ9gaJpZM4K8y2p> .

-- +919971876580 twitter: @jacobSingh ( http://twitter.com/#!/JacobSingh ) web: http://www.jacobsingh.name Skype: pajamadesign gTalk: jacobsingh@gmail.com

[fp12]

Oh yeah you're right it needs an update indeed! I'll give it a shot! Thanks!

[PeterCat12]

@fp12 What are the chief differences between your library and @ZEDGR 's library? When it comes to making an async request to challonge when would you want to vs when would you not want to? (can I choose to do either with your lib or does it always make an async request?) debating which library to grab.

[fp12]

@PeterCat12 it really depends on your setup: async is for python 3.4+. I ported it to be async since I was working a full async environment (Discord Bot), but both versions are functionally the same. If @ZEDGR has some extra feature, I'll gladly port them into my fork!

[jacobSingh]

The reason I chose async is that it's just generally preferred. You can make it blocking easily enough by calling it with await, but it means I can get 10 matches at once, instead of one. If I'm processing 20k matches this makes a big difference. Best, J

…

On Mon, Dec 12, 2016 at 8:33 AM, fp12 ***@***.***> wrote: @PeterCat12 <https://github.com/PeterCat12> it really depends on your setup: async is for python 3.4+. I ported it to be async since I was working a full async environment (Discord Bot), but both versions are functionally the same. If @ZEDGR <https://github.com/ZEDGR> has some extra feature, I'll gladly port them into my fork! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/russ-/pychallonge/issues/12#issuecomment-266333342>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHchrMoAOpJw103PnjTx1ZX79CpKVgVks5rHLmFgaJpZM4K8y2p> .

-- +919971876580 twitter: @jacobSingh ( http://twitter.com/#!/JacobSingh ) web: http://www.jacobsingh.name Skype: pajamadesign gTalk: jacobsingh@gmail.com

[PeterCat12]

@fp12 Hey, I'm having some trouble getting your fork to run. Using your readme I've ran pip install -e git+http://github.com/fp12/pychallonge_async#egg=pychallonge_async but everytime I try to use your library I get No module named 'challonge'. I've also tried importing pychallonge_asyn but I get a similar response... Any idea what I am doing incorrectly? Do I have to have the original repo (pychallonge) installed in addition to yours or something?

[fp12]

Do you mind opening another issue on my fork for this?
I'll check what could be wrong in the meantime.
Many thanks!

[PeterCat12]

Hey, I would have but I only see the option to open PR's on your repo (Likewise for Zedger's fork). Not sure if this is a permissions issue or if GitHub only allows issues to be opened on the original repo?

[fp12]

@PeterCat12 Issues weren't activated on my fork for some reason... Now they should be.
Can you give it a try? Thanks!

[PeterCat12]

Will do. Thanks @fp12 !