rust-bitcoin/murmel

DoS protection outgoing message queue

tamasblummer opened this issue · 3 comments

tamasblummer commented

The outgoing message queue (P2PControl) is not bounded, therefore easy to DoS the node by asking e.g. for many blocks and not consuming themm, this would consume all RAM with the queue. Limiting the queue would stop unrelated processing once the queue is full and give rise to yet another DoS vulnarebility. Ideally outgoing messages should be just dropped if a peer did not consume previous fast enough, after all this is not our problem.

TigerInYourDream commented

HI, will it work in a few days? I asked this question a month ago. I want to find an spv client in rust that worked.

tamasblummer commented

It works. Eg. used in https://github.com/defiads/defiads to connect to two p2p network bitcoin and defiad's own.

TigerInYourDream commented

It works. Eg. used in https://github.com/defiads/defiads to connect to two p2p network bitcoin and defiad's own.

Thanks for the reply!