rust-cli/confy

Update directories crate (and others ?) before next version

Closed this issue · 4 comments

Zykino commented

The directories crate has a breaking change when upgrading to version 3 (specifically macOS change). https://github.com/dirs-dev/directories-rs#3
I did not check more, but I will before making a PR.

matthiasbeyer commented

Thanks for reporting this! This might have an influence on our release number as well (0.5.0 instead of 0.4.1 or something like that).

Zykino commented

I think next version should be 0.5.0 anyway since yaml was added. But maybe adding a feature does not requires bumping the "major" revision ?
Anyway #37 add an "optional" parameter and so change the definition of load and store.

  • 👍1
matthiasbeyer commented

But maybe adding a feature does not requires bumping the "major" revision ?

As we are in 0.x.y, we only should bump the minor version, not the major.

  • 👍1
Dylan-DPC-zz commented

yeah directories-next is a change of behaviour, so it makes sense to propagate this change downstream so it makes sense to have a major (0.5) release.