rust-embedded/nb

Ship a 1.0 release

thejpster opened this issue · 4 comments

thejpster commented

Part of rust-embedded/wg#383

Add blocking issues here:

  • can run cargo test neither on stable nor on unstable - #24
  • Review against https://rust-lang.github.io/api-guidelines/ - #31
  • Document MSRV - #30
  • Remove unstable feature - #32
  • CI on GHA + bors - #23 #24
  • Only include await! in Rust nightly via build.rs? - #28
  • Bump version in cargo.toml - #33
  • Add version section in changelog - #33
  • Release 0.1.3 semver-trick version - #34
  • 🎉
hannobraun commented

I guess the main blocking issue would be, whether this crate offers the right approach at all, and whether/how it needs to change (or be discarded completely) in the face of the async stuff that already landed in Rust, and is yet to come. See #14, rust-embedded/embedded-hal#149, and rust-embedded/embedded-hal#172.

  • 👍2
eldruin commented

I would nominate #22 for this.

eldruin commented

Further TODOs:

jonas-schievink commented
  • Remove unstable feature
  • Only include await! in Rust nightly via build.rs?

I prefer the current approach of having to opt into unstable features. It mirrors how unstable features in Rust work, and if we automatically enable unstable feature for nightly Rust versions people could accidentally start using an unstable feature in this library just because their installation happens to default to the nightly Rust channel (which is a reasonable thing to do in order to use unstable compiler flags and benefit from recent performance improvements, etc.).