rust-lang/highfive

r? doesn't work in a review comment

varkor opened this issue · 5 comments

varkor commented

When making a review, if r? is used in (at least the main comment of) the review, @rust-highfive won't pick up on it.

davidalber commented

There's at least two issues here:

  1. The webhook in each of the repositories using Highfive is not configured to send review events to Highfive.
  2. Even if Highfive were receiving those events, it would ignore them.

Fixing the first one takes changing settings in each of the repos using Highfive. The second one is some dev work in this repository.

Alternatively, I have been thinking about proposing changing Highfive to be a GitHub app, which would make situations like this easier to address, but there are other issues to handle before that is possible.

davidalber commented

For exposition, do you have a link to an issue where you used r? in a review comment?

varkor commented

I originally posted it in rust-lang/rust#56203 (review) (but since then, I removed the r? in an edit once I saw that it didn't work).

dwijnand commented

(Oh, I just realised this was about r?, not r+.)

pietroalbini commented

Just as a note, changing the configuration of the webhook across all repos is now trivial thanks to the update-webhooks.py script.