rust-lang/highfive

Exception when handling custom mentions

pietroalbini opened this issue · 2 comments

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 2292, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1815, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1718, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1813, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1799, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python2.7/dist-packages/highfive/app.py", line 45, in new_pr
    return handler.run(flask.request.headers['X-GitHub-Event'])
  File "/usr/local/lib/python2.7/dist-packages/highfive/newpr.py", line 71, in run
    self.new_pr()
  File "/usr/local/lib/python2.7/dist-packages/highfive/newpr.py", line 377, in new_pr
    author, to_mention
  File "/usr/local/lib/python2.7/dist-packages/highfive/newpr.py", line 133, in set_assignee
    message += "%s\n\ncc %s" % (mention['message'],
KeyError: 'message'

highfive/highfive/newpr.py

Lines 133 to 134 in 748c035

message += "%s\n\ncc %s" % (mention['message'],
','.join([x for x in mention['reviewers'] if x != user]))

@GuillaumeGomez

This is probably the cause of rust-lang/rust#60515 (comment)

Perfect, thanks for the backtrace! I'll send a fix later on today.