rust-highfive only warns about updated submodules when a PR is created

Question

rust-highfive only warns about updated submodules when a PR is created

varkor opened this issue 5 years ago · 4 comments

Or maybe it also warns when a new commit is pushed, but definitely not when commits are force pushed (as seen in rust-lang/rust#62235).

Answer 1 · 2021-05-24T21:07:27.000Z

Looking at app.py, it seems like highfive only ever runs on new PRs, never changes. Someone will need to add the ability to look at changes to highfive (or more likely, rewrite the whole thing into triagebot). @Mark-Simulacrum do you have opinions on which is the right approach?

Answer 2 · 2021-07-16T16:49:27.000Z

The issue also applies to pinging teams when a PR touches code in their responsibility.

Answer 3 · 2022-06-27T00:22:40.000Z

I have opened a PR at rust-lang/triagebot#1625 which aims to solve this issue (and moves "mentions" to triagebot).

Answer 4 · 2022-06-28T01:54:56.000Z

This should now essentially be fixed in triagebot, so I think this could probably be closed.