rust-lang/highfive

highfive should not assign someone to their own PR

joshtriplett opened this issue · 3 comments

In rust-lang/rust#84257 , rust-highfive assigned me to review my own PR.

That's weird. It specifically excludes the author of the PR here:

reviewers.remove(exclude)

Which comes from the last argument here:

highfive/highfive/newpr.py

Lines 384 to 386 in a2e3b19

reviewer = self.choose_reviewer(
repo, owner, diff, author
)

Set here:

author = self.payload['pull_request', 'user', 'login']

Ah, the casing of your username in the high-five config doesn't match the one github uses: JoshTriplett vs joshtriplett

If you click [edit] on rust-lang/rust#84257 (comment), you can see the bot is using JoshTriplett and not joshtriplett (even though github shows the former as the latter).

image
image

@m-ou-se Ah, interesting. Ideally the bot should match ignoring case the same way GitHub does, but in the meantime, it sounds like the easiest fix would be to change my username in the configuration to all-lowercase.