We should be enforcing constness predicates on all call-like things in HIR typeck

Question

We should be enforcing constness predicates on all call-like things in HIR typeck

Opened this issue a year ago · 2 comments

Right now we're (afaict) missing autoderefs which are applied as adjustments. Specifically interesting is the answer to the question of where do we put that enforce_context_effects call...

We're possibly also missing other things, so a full audit of HIR typeck is probably worthwhile.

Answer 1 · 2024-10-25T06:07:59.000Z

Can we do this in the MIR const check to be sure we don't miss anything?

Answer 2 · 2024-10-25T07:52:00.000Z

@RalfJung: Sure, we can do it for the purposes of making sure nothing non-const leaks into the body in MIR const checking, but I'd prefer that for the purposes of diagnostics that we enforce this first in HIR typeck. This is consistent with HIR and MIR checking traits first; if something fails to satisfy a const trait predicate in MIR, we delay a bug.