rust-lang/rustc-dev-guide

`llvm-coverage-instrumentation.md`: borked links

marxin opened this issue · 4 comments

The following errors are related to the file:

error: Server returned 404 Not Found for https://github.com/rust-lang/rust/blob/master/tests/mir-opt/instrument_coverage.rs
    ┌─ llvm-coverage-instrumentation.md:316:1
    │
316 │ [`tests/mir-opt/instrument_coverage.rs`].
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://github.com/rust-lang/rust/blob/master/tests/mir-opt/instrument_coverage.rs

error: Server returned 404 Not Found for https://github.com/rust-lang/rust/tree/master/tests/run-make/coverage-llvmir
    ┌─ llvm-coverage-instrumentation.md:335:14
    │
335 │ Finally, the [`coverage-llvmir`] test compiles a simple Rust program
    │              ^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://github.com/rust-lang/rust/tree/master/tests/run-make/coverage-llvmir

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/struct.Instrumentor.html
    ┌─ llvm-coverage-instrumentation.md:359:8
    │
359 │ by the [`Instrumentor`][instrumentor]. For each MIR (each non-const, non-inlined
    │        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/struct.Instrumentor.html

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/struct.Instrumentor.html#method.inject_counters
    ┌─ llvm-coverage-instrumentation.md:362:1
    │
362 │ [`inject_counters()`][inject-counters].
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/struct.Instrumentor.html#method.inject_counters

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html#method.generate_coverage_spans
    ┌─ llvm-coverage-instrumentation.md:380:4
    │
380 │ 1. [`generate_coverage_spans()`][generate-coverage-spans] computes the minimum set of distinct,
    │    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html#method.generate_coverage_spans

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/counters/struct.BcbCounters.html#method.make_bcb_counters
    ┌─ llvm-coverage-instrumentation.md:383:4
    │
383 │ 2. [`make_bcb_counters()`][make-bcb-counters] generates `BcbCounter::Counter`s and
    │    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/counters/struct.BcbCounters.html#method.make_bcb_counters

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html
    ┌─ llvm-coverage-instrumentation.md:468:14
    │
468 │ The `struct` [`CoverageSpans`][coverage-spans] builds and refines a final set of
    │              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpan.html
    ┌─ llvm-coverage-instrumentation.md:469:1
    │
469 │ [`CoverageSpan`][coverage-span]s, each representing the largest contiguous `Span`
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpan.html

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html#method.generate_coverage_spans
    ┌─ llvm-coverage-instrumentation.md:474:1
    │
474 │ [`CoverageSpans::generate_coverage_spans()`][generate-coverage-spans] constructs
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html#method.generate_coverage_spans

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html#method.to_refined_spans
    ┌─ llvm-coverage-instrumentation.md:479:1
    │
479 │ [`to_refined_spans()`][to-refined-spans], which iterates through the `CoverageSpan`s,
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/spans/struct.CoverageSpans.html#method.to_refined_spans

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/counters/struct.BcbCounters.html#method.make_bcb_counters
    ┌─ llvm-coverage-instrumentation.md:489:1
    │
489 │ [`make_bcb_counters()`][make-bcb-counters] traverses the `CoverageGraph` and adds a
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/coverage/counters/struct.BcbCounters.html#method.make_bcb_counters

I noticed the most changes were done by @Zalathar. Can you please take a look at them?

How can I reproduce these errors?

The readme claims that mdbook build will also perform linkcheck, but I'm not seeing any errors locally.

You're affected by the current issue with file filtering: #2019. Anyway, I use GITHUB_EVENT_NAME=schedule mdbook build to check all files.

That still gives me an error about not having a GITHUB_TOKEN. I might have to rely on the error listing above, and PR CI.

That still gives me an error about not having a GITHUB_TOKEN.

Yes, that's correct, but you should still be able to see all the linkcheck errors.