rust-secure-code/cargo-auditable

Cargo.lock is outdated

figsoda opened this issue · 11 comments

figsoda commented
Cargo.lock is outdated
Shnatsel commented

Oh, yeah, it is. It's a one-line change, I've pushed the new one.

Is there anything else you need me to do or can I close this?

  • ❤️1
figsoda commented

It would be nice to have a v0.5.4 tag as well

you can close this

Shnatsel commented

Oh. I forgot to push the tag. Done, thanks!

figsoda commented

the tag is pinned to the outdated Cargo.lock, could you maybe publish a new version?

Shnatsel commented

I've repointed the tag to the up-to-date Cargo.lock

bjorn3 commented

Git doesn't pull changes to tags if you already pulled the old version.

Shnatsel commented

Riiiiight. Ugh.

Is there any reasonable way to recover other than publishing a new release? If not I'll just go ahead and do that.

figsoda commented

one thing i can think of is tag something like v0.5.4-cargo-lock or just not recovering at all

Shnatsel commented

Is this actually an issue for some build process somewhere? I'm not sure what the impact of the not-bumped Cargo.lock is, exactly.

figsoda commented

nixpkgs builds it with --frozen, the impact is just that we need to patch it Cargo.lock to make it up to date

Shnatsel commented

Alright, so I've moved the 0.5.4 tag to the commit containing the updated Cargo.lock file. If that's problematic for some reason, 0.5.3 can be used (the only changes are in the README.md) or a git snapshot can be packaged.

I'm going to leave it at that for this release, but I've opened #86 to prevent such issues happening in the future.