Displays wrong time on days of the year that go from regular time to DST or the opposite way
Closed this issue · 7 comments
Since that will span DST changes that will yield an error (running an hour fast today in NL)
Make that:
date = new Date()
hours = date.getHours();
minutes = date.getMinutes();
seconds = date.getSeconds();
time = hours * 60 * 60 * 1000 + minutes * 60 * 1000 + seconds * 1000;
Hey, nice to see that people are still using this ^^
If that is alright with you I'd just use your code (albeit a little modified) and I'll add a notice to the README.MD about how you found the issue and suggested the change. (i.e. your code would fall under the same MIT license as the rest of the code, but you'd get a mention).
A small heads up: I no longer own a Mac and as such I also no longer use Übersicht. I'll probably archive this repository after this issue is resolved. If you'd like I could also transfer the repo to you.
I'm fine with that. No problem. I'd be happy to maintain it - I think I will be using Macs for some time :-)
Alright, then I'll push the fix now and transfer ownership to you :)
Top! 👍
I'll talk to the Übersicht guy. He's a Dutchie too...
Sweet, thanks for that (btw. sorry about the deleted comment... I may or may not have written that with the wrong account)
Transferred all in good order. No need to worry about that comment - you have been very forthcoming.