tests failing on node 5
yoshuawuyts opened this issue · 1 comments
yoshuawuyts commented
Running the unmodified tests on node 5.0
fail; it might be a good idea to add greenkeeper
/ travis
so this can be caught early next time. Ran into this while quickly testing if I could pull in quick-format to improve perf. Thanks!
> bole@2.0.0 test /Users/yw/src/bole
> node test.js
TAP version 13
# test simple logging
ok 1 should be equal
# test multiple logs
ok 2 should be equal
# test multiple outputs
ok 3 should be equal
ok 4 should be equal
ok 5 should be equal
ok 6 should be equal
# test string formatting
ok 7 should be equal
ok 8 should be equal
ok 9 should be equal
ok 10 should be equal
ok 11 should be equal
ok 12 should be equal
ok 13 should be equal
# test error formatting
ok 14 should be equal
# test error formatting with message
ok 15 should be equal
# test request object
not ok 16 should be equal
---
operator: equal
expected:
'{"time":"2016-03-21T03:06:34.xxxZ,"hostname":"Yoshuas-MacBook-Pro.local","pid":95098,"level":"info","name":"reqfmt","req":{"method":"GET","url":"/foo?bar=baz","headers":{"host":":58575","connection":"close"},"remoteAddress":"127.0.0.1","remotePort":"RPORT"}}\n'
actual:
'{"time":"2016-03-21T03:06:34.xxxZ,"hostname":"Yoshuas-MacBook-Pro.local","pid":95098,"level":"info","name":"reqfmt","req":{"method":"GET","url":"/::/foo?bar=baz","headers":{"host":":58575","connection":"close"},"remoteAddress":"127.0.0.1","remotePort":"RPORT"}}\n'
...
# test request object with message
not ok 17 should be equal
---
operator: equal
expected:
'{"time":"2016-03-21T03:06:34.xxxZ,"hostname":"Yoshuas-MacBook-Pro.local","pid":95098,"level":"info","name":"reqfmt","message":"this is a message","req":{"method":"GET","url":"/foo?bar=baz","headers":{"host":":58577","connection":"close"},"remoteAddress":"127.0.0.1","remotePort":"RPORT"}}\n'
actual:
'{"time":"2016-03-21T03:06:34.xxxZ,"hostname":"Yoshuas-MacBook-Pro.local","pid":95098,"level":"info","name":"reqfmt","message":"this is a message","req":{"method":"GET","url":"/::/foo?bar=baz","headers":{"host":":58577","connection":"close"},"remoteAddress":"127.0.0.1","remotePort":"RPORT"}}\n'
...
# test sub logger
ok 18 should be equal
# test object logging
ok 19 correct number of log entries
ok 20 correct log entry #0
ok 21 correct log entry #1
ok 22 correct log entry #2
ok 23 correct log entry #3
1..23
# tests 23
# pass 21
# fail 2
rvagg commented
fixed, listening to localhost explicitly now and it's cool