ryan-haskell/elm-date-format

'Suffixed' instead of 'Suffix'?

Closed this issue · 0 comments

Looking through the API a bit more closely I'm wondering if things like monthSuffix would make more sense as monthSuffixed (or even monthNumberSuffixed if you wanted to be extra explicit/verbose). monthSuffix sounds like it might be just the suffix (e.g. 'st', 'nd', 'rd') which you would use as

DateFormat.format [ DateFormat.monthNumber, DateFormat.monthSuffix ] date
--> '3rd'

This is obviously pretty minor so I don't think it's worth making a breaking change for all by itself, but perhaps something to consider if and when you do release a new major version (or upgrade to Elm 0.19). Apologies for not thinking of this earlier during the discussion on Slack =)