ryanande/JsCombGuid

Moment uses 0 based index for month

tellingson opened this issue · 1 comments

I would recommend changing moment([1900, 1, 1]), "days") to moment([1900, 0, 1]), "days")

Currently it is using February 1st instead of January 1st.

It works as is as long as it is the only thing being used, but if you have multiple sources (SQL, C#, Javascript) generating the CombGuids, then it needs to be changed.

Nice catch! Been awhile since I have looked at this code.
#2
Merged.