Library does not follow node idiomatic error first callback

Question

Library does not follow node idiomatic error first callback

Closed this issue 10 years ago · 5 comments

All libraries in node return the error first in the callback, then the response. This module returns an array with the error or the response which is not friendly with other modules like async or syncho that expects an error first in the callback.

Answer 1 · 2014-11-09T23:39:45.000Z

Yep, this is poorly done. I'll fix it soon.

Answer 2 · 2014-11-10T01:02:02.000Z

I can submit a PR if you want but I don't see how this fix could be backward compatible.

Answer 3 · 2014-11-10T01:15:43.000Z

It definitely won't be, but it's the right thing to do. If you want to submit a PR, I'll be happy to take a look

Answer 4 · 2014-11-10T04:09:04.000Z

I published this to NPM with a new major number to signify that it's a breaking change.

Answer 5 · 2014-11-10T04:46:26.000Z

Awesome. Thanks for the fast follow-up!

On Mon, Nov 10, 2014 at 3:09 PM, Ryan Breen notifications@github.com
wrote:

I published this to NPM with a new major number to signify that it's a
breaking change.

—
Reply to this email directly or view it on GitHub
#4 (comment)
.